Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new associate methods #131

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Document new associate methods #131

merged 2 commits into from
Sep 17, 2024
+58 −0

Conversation

mj850
Copy link
Collaborator

@mj850 mj850 commented Sep 4, 2024

What is the purpose of the change?

Add documentation about the new associate methods in the addr precompile

Describe the changes to the documentation

Documentats the new associate methods in the addr precompile, including examples for how to use them.

Notes

@mj850 mj850 requested a review from a team as a code owner September 4, 2024 23:09
besated
besated approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@besated besated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i might've missed it, but does this include the method to associate via pubkey?

dssei
dssei reviewed Sep 16, 2024
View reviewed changes
pages/dev-interoperability/precompiles/addr.mdx Outdated
@@ -11,6 +11,64 @@ Association takes place when the wallet first signs and broadcasts any transacti

## Functions

### Transactions
- `associate`: Associates an EVM address with it's corresponding Cosmos address on chain using a signature. For association via a pubkey, use `associatePubKey` instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Cosmos -> Sei native

@cordt-sei
Copy link
Contributor

cordt-sei commented Sep 17, 2024 •
edited
Loading

i might've missed it, but does this include the method to associate via pubkey?

@besated yes I asked the same thing because it looks so familiar. It is basically the same as before, except you can do it for the other wallet without that wallet having 1 wei now.

@mj850 mj850 merged commit 0cd7584 into main Sep 17, 2024
1 check passed
@mj850 mj850 deleted the mj/addrPrecompile branch September 17, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dssei dssei dssei left review comments

@besated besated besated approved these changes

@cordt-sei cordt-sei cordt-sei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mj850 @cordt-sei @besated @dssei